Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include AllowedSystemId also in PlaceRef #204

Merged

Conversation

ue71603
Copy link
Contributor

@ue71603 ue71603 commented Jun 2, 2022

....and perhaps we even should add it more generally depending on the algorithms.
The people working with EU spirit and HaCon/MENTZ should take a look.

@ue71603 ue71603 added this to the v2.0 milestone Jun 2, 2022
@ue71603 ue71603 added enhancement New feature or request documentation labels Jun 2, 2022
@JonaVBB
Copy link

JonaVBB commented Jun 3, 2022

Disclaimer: I may understand this imperfectly.
The role of the AllowedSystemId may differ. In EU-Spirit it is used in InitialInput to tell the RCC to which passive servers the request shall be passed. [In EU-Spirit the OJP services do not interact directly, but only via the RCC].
I understand that there may be an advantage to have the AllowedSystemId information available outside the InitialInput. Maybe you could elaborate a bit more what kind of procedure you have in mind. Do you want to have a chane to get an overview about available systems automatically before the actual request?

@skinkie skinkie changed the title Include AllowedSystemId also in PlaceREf Include AllowedSystemId also in PlaceRef Jul 20, 2022
@ue71603
Copy link
Contributor Author

ue71603 commented Jul 25, 2022

@JonaVBB I think that in a distributed context it is sometimes necessary to know which system is the "owner/master" of the element (here place). In theory otherwise they might have the same id. i would add a SystemId everywhere, where this distinction is necessary. may be also in TripInfoRequest. What do you think?

@ue71603
Copy link
Contributor Author

ue71603 commented Sep 1, 2022

@JonaVBB could you please comment?

herlitze
herlitze previously approved these changes Oct 2, 2022
@ue71603 ue71603 requested review from skinkie and herlitze October 18, 2022 16:39
....and perhaps we even should add it more generally depending on the algorithms.
@sgrossberndt sgrossberndt force-pushed the distributed_systemid-not-only-in-InitialInput branch from 20c6b77 to 245a69a Compare October 19, 2022 07:08
OJP/OJP_PlaceSupport.xsd Show resolved Hide resolved
@JonaVBB
Copy link

JonaVBB commented Oct 19, 2022

To me it seems we're talking about two different ways of using this element (spoiler: I don't see a problem using both in parallel).

The initial idea from EU-Spirit derives from EU-Spirit's algorithm. AllowedSystemId is used by active servers/nodes to tell the RCC (central component) which passive servers/nodes shall be used to calculate the journey. So, AllowedSystemId is then a list of IDs which are allowed/defined to be asked. Passive systems which are not mentioned in the AllowedSystemId will not be asked by the RCC.
Second aspect (and new for me, but still ok): if I understand it correctly, you would put an AllowedSystemId in each part of responses to "assign" certain elements to a system they are originating from. Am I right? Yes, this might help.

@ue71603 ue71603 requested a review from sgrossberndt October 26, 2022 12:34
@sgrossberndt sgrossberndt merged commit 55bbdd9 into changes_for_v1.1 Nov 7, 2022
@sgrossberndt sgrossberndt deleted the distributed_systemid-not-only-in-InitialInput branch November 7, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc updated enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants